Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/relnote: look for CLs that had revert CLs sent (but abandoned) #37751
If a change has a revert CL sent, and later the revert CL gets abandoned, it's likely that the original change is significant enough to be considered for inclusion in release notes. We can detect this fairly easily with maintner's corpus.
For an example where this would've helped, see #29384 (comment). A revert CL was sent, but then abandoned. It could've helped detect that we should include the original CL in the release notes; see #37614.
Maybe? But sometimes the revert is due to a failure in a newly-added test, and is abandoned because the test fix is very simple and applied quickly.
A corresponding issue without the