Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/relnote: look for CLs that had revert CLs sent (but abandoned) #37751

Open
dmitshur opened this issue Mar 9, 2020 · 2 comments
Open

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 9, 2020

If a change has a revert CL sent, and later the revert CL gets abandoned, it's likely that the original change is significant enough to be considered for inclusion in release notes. We can detect this fairly easily with maintner's corpus.

For an example where this would've helped, see #29384 (comment). A revert CL was sent, but then abandoned. It could've helped detect that we should include the original CL in the release notes; see #37614.

/cc @cagedmantis @toothrot @ianlancetaylor @mvdan

@bcmills
Copy link
Member

@bcmills bcmills commented Mar 9, 2020

Maybe? But sometimes the revert is due to a failure in a newly-added test, and is abandoned because the test fix is very simple and applied quickly.

A corresponding issue without the Testing label would probably be a higher-confidence signal, but if we have an open issue about an API change anyway, that should be labeled Documentation and release-blocker if the change is not reverted.

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Mar 9, 2020

Good points @bcmills. We should be mindful of false-positives this might create.

I was imagining if this is implemented, relnote would emit a new section that humans can review and make decisions on what to keep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.