Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: implement strict TLS 1.3 downgrade protections #37763

Open
FiloSottile opened this issue Mar 9, 2020 · 1 comment
Open

crypto/tls: implement strict TLS 1.3 downgrade protections #37763

FiloSottile opened this issue Mar 9, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Mar 9, 2020

RFC 8446, Section 4.1.3 mandates strict downgrade checks in TLS 1.3. crypto/tls currently sends the downgrade canaries but doesn't check them, because the ecosystem had some off-spec implementations that had to be flushed out.

We should switch the detection on for Go 1.15, on a similar schedule as Chrome. https://groups.google.com/a/chromium.org/d/msg/blink-dev/CK0Xxdz-4Mg/KIOaBAXmBQAJ

This is arguably a risky change, so it should be flagged appropriately.

@FiloSottile FiloSottile added the NeedsFix label Mar 9, 2020
@FiloSottile FiloSottile added this to the Go1.15 milestone Mar 9, 2020
@FiloSottile FiloSottile self-assigned this Mar 9, 2020
@OneOfOne

This comment has been minimized.

Copy link
Contributor

@OneOfOne OneOfOne commented Mar 9, 2020

Just throwing ideas, but IMHO that change should be around a flag of sorts in case someone's server has to deal with broken clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.