Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/blake2[b|s]: clarify the difference between the two blake2 packages in the godoc #37784

Open
katiehockman opened this issue Mar 10, 2020 · 1 comment
Assignees
Milestone

Comments

@katiehockman
Copy link
Member

@katiehockman katiehockman commented Mar 10, 2020

x/crypto provides two implementations for blake2 hashing: blake2s and blake2b. Looking at the docs, there is no description for why someone should prefer one package over the other.

blake2.net says this:

BLAKE2 comes in two flavors:

  • BLAKE2b (or just BLAKE2) is optimized for 64-bit platforms—including NEON-enabled ARMs—and produces digests of any size between 1 and 64 bytes
  • BLAKE2s is optimized for 8- to 32-bit platforms and produces digests of any size between 1 and 32 bytes

The docs for these two packages should say something similar to inform users when making a choice.

/cc @FiloSottile

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Apr 1, 2020

Change https://golang.org/cl/226845 mentions this issue: blake2b,blake2s: clarify optimizations of each function in docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.