x/tools/refactor/importgraph: TestBuild is failing sometimes #37823
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
okay-after-beta1
Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1
release-blocker
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
dmitshur
added
the
NeedsInvestigation
gopherbot
added
the
Tools
|
Have these failures been occurring at a particular version of Go? This package uses go/build to get its information so I'm guessing the failures are related to that. Maybe there's been a in go/build or cmd/go that's causing this. I wonder if it has to do with the test not setting GO111MODULE=off... |
|
Change https://golang.org/cl/367846 mentions this issue: |
bcmills
added
okay-after-beta1
|
Marking as release-blocker for Go 1.18 via #11811. I have what I believe to be a fix CL pending. |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Nov 30, 2021
…rs from Build This test was written for GOPATH mode, and subsequently updated to use packagestest at a time when GO111MODULE defaulted to "auto" (in this case, off). As a result, the test was failing to set environment variables relevant to the test, such as GO111MODULE=off. The missing environment was causing errors that were subsequently masked by a missing error check: the errors returned by importgraph.Build were only read in an "if false" block. This CL adds the missing environment variables and error checks. Using the correct environment may or may not fix the observed test failures. For golang/go#37823 Change-Id: I75844e6fdf47222aa4f953c8c4fbcc93cec606c9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/367846 Trust: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm seeing frequent failures that look like this at https://build.golang.org/?repo=golang.org%2fx%2ftools on the darwin builders:
For a recent example, see https://build.golang.org/log/5b156a1c79480768102921c27ab1b16ccc7c0590.
/cc @matloob
The text was updated successfully, but these errors were encountered: