Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: high CPU on leftover daemon process after update #37829

Open
findleyr opened this issue Mar 12, 2020 · 3 comments
Open

x/tools/gopls: high CPU on leftover daemon process after update #37829

findleyr opened this issue Mar 12, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@findleyr
Copy link

@findleyr findleyr commented Mar 12, 2020

Forked from @zikaeroh's comment on #34111:
#34111 (comment)

One thing I've noticed after doing a couple of gopls upgrades with this enabled is that the unused process seems to use CPU when I change my project's files even when no session is attached (e.g. I ask VSC to restart the language server, I get a new gopls serve process as the build ID changed, then edit a file while watching htop).

Is gopls doing some sort of extra file watching? I had thought it was only using LSP's file watcher, but the fact that it's responding to edits for files it doesn't have "open" is strange.

@findleyr findleyr self-assigned this Mar 12, 2020
@zikaeroh

This comment has been minimized.

Copy link
Contributor

@zikaeroh zikaeroh commented Mar 12, 2020

Note that the update here is on gopls, not VS Code itself (though I do trigger an "update" by asking it to restart gopls and it runs the new binary).

@gopherbot gopherbot added this to the Unreleased milestone Mar 12, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Mar 12, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@findleyr findleyr changed the title x/tools/gopls: high CPU on leftover daemon process after VSCode update x/tools/gopls: high CPU on leftover daemon process after update Mar 12, 2020
@findleyr

This comment has been minimized.

Copy link
Author

@findleyr findleyr commented Mar 12, 2020

Thanks, that's what I meant (an update triggered from VSCode) but it was poorly worded. Updated the title.

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.4.0 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.