Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: functions with type switches cannot be inlined #37837

Closed
aebrahim opened this issue Mar 13, 2020 · 2 comments
Closed

cmd/compile: functions with type switches cannot be inlined #37837

aebrahim opened this issue Mar 13, 2020 · 2 comments

Comments

@aebrahim
Copy link

@aebrahim aebrahim commented Mar 13, 2020

What version of Go are you using (go version)?

$ go version
go version go1.14 linux/amd64

Does this issue reproduce with the latest release?

N/A 1.14 is the latest release

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"

What did you do?

go build -gcflags="-m -m" demo.go
demo.go.txt

What did you expect to see?

Inlining of small function after #13071

What did you see instead?

./demo.go:15:6: cannot inline SomeFunc: unhandled op TYPESW

@randall77 randall77 added this to the Unplanned milestone Mar 13, 2020
@randall77
Copy link
Contributor

@randall77 randall77 commented Mar 13, 2020

I think we just need to figure out what cost we should assign it.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 29, 2020

Change https://golang.org/cl/266203 mentions this issue: cmd/compile: support inlining of type switches

@gopherbot gopherbot closed this in 5736eb0 Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.