Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: -vv flag interfere with output of env command #3788

Closed
alexbrainman opened this issue Jun 30, 2012 · 3 comments
Closed

cmd/dist: -vv flag interfere with output of env command #3788

alexbrainman opened this issue Jun 30, 2012 · 3 comments

Comments

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jun 30, 2012

# go tool dist env -vv >a
# cat a
GOROOT="/root/hg/go"
GOBIN="/root/hg/go/bin"
GOARCH="386"
GOOS="linux"
GOHOSTARCH="386"
GOHOSTOS="linux"
GOTOOLDIR="/root/hg/go/pkg/tool/linux_386"
GOCHAR="8"
rm -rf /var/tmp/go-cbuild-LstMR4
#

We do not want

rm -rf /var/tmp/go-cbuild-LstMR4

line in file a.
@PieterD
Copy link
Contributor

@PieterD PieterD commented Jun 30, 2012

Comment 1:

I recognize this :)
Options are to allow dist env to write to a file, or to make all verbose messages print
to stderr.
The first is a smaller change to cmd/dist, but also requires a change to the build
scripts. The second option is a bit more sweeping, but at least leaves everything but
cmd/dist alone.
@alexbrainman
Copy link
Member Author

@alexbrainman alexbrainman commented Jun 30, 2012

Comment 2:

I am not sure which option is preferred. Feel free to do what you think is right. If you
are wrong, reviewers will correct you and, hopefully, explain why.
Alex
@alexbrainman
Copy link
Member Author

@alexbrainman alexbrainman commented Jul 6, 2012

Comment 3:

This issue was closed by revision 34b10d7.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.