Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: clicking a link to an anchor for an example does not show the example #37884

Closed
dcormier opened this issue Mar 16, 2020 · 2 comments
Closed

x/pkgsite: clicking a link to an anchor for an example does not show the example #37884

dcormier opened this issue Mar 16, 2020 · 2 comments
Labels
NeedsFix Suggested help wanted pkgsite
Milestone
pkgsite/unplanned

Comments

@dcormier
Copy link
Contributor

@dcormier dcormier commented Mar 16, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/aws/aws-sdk-go/service/dynamodb/expression?tab=doc#pkg-examples

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:73.0) Gecko/20100101 Firefox/73.0

Screenshot

Clicking this link (bottom of image):

image

Results in the browser going here:

image

What did you do?

I clicked a link in the Examples section.

What did you expect to see?

The example I clicked.

What did you see instead?

I saw the page just below the anchor for the example, with the anchor itself hidden by the page navigation header and not visible at all.
@gopherbot gopherbot added this to the Unreleased milestone Mar 16, 2020
@gopherbot gopherbot added the pkgsite label Mar 16, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Mar 17, 2020

This issue seems to be related to #37520. Also related - #37819.
@julieqiu julieqiu added UX NeedsInvestigation labels Mar 17, 2020
@julieqiu julieqiu changed the title go.dev: clicking a link to an anchor for an example does not show the example x/pkgsite: clicking a link to an anchor for an example does not show the example Jun 15, 2020
@julieqiu julieqiu added help wanted NeedsFix Suggested and removed NeedsInvestigation UX labels Jun 15, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 27, 2020

This fix is now live on pkg.go.dev.
@julieqiu julieqiu closed this Aug 27, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/unreleased Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Suggested help wanted pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@dcormier @julieqiu @gopherbot