Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/acme: better document Register behavior when account already exists #37889

Open
rolandshoemaker opened this issue Mar 16, 2020 · 2 comments

Comments

@rolandshoemaker
Copy link
Member

@rolandshoemaker rolandshoemaker commented Mar 16, 2020

Currently when Client.Register is called and an account already exists the behavior diverges based on the server implementation. If the server is pre-8555 it just returns the account object and no error, if it is 8555 compliant it returns no account object and a ErrAccountAlreadyExists error. In the latter case it will also store the account KID internally, allowing for follow-up requests (although this is not documented).

Ideally for 8555 servers Client.Register should return the account object when it already exists (perhaps in conjunction with the ErrAccountAlreadyExists error) so that the user doesn't have to do two requests to actually get the object (Client.Regiser and Client.GetReg), but at the least the documentation should be improved to actually say what happens in this circumstance.

@gopherbot gopherbot added this to the Unreleased milestone Mar 16, 2020
@rolandshoemaker rolandshoemaker changed the title x/crypto/acme/autocert: Better document Register behavior when account already exists x/crypto/acme: Better document Register behavior when account already exists Mar 16, 2020
@cagedmantis cagedmantis changed the title x/crypto/acme: Better document Register behavior when account already exists x/crypto/acme: better document Register behavior when account already exists Mar 18, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Mar 20, 2020

@gopherbot
Copy link

@gopherbot gopherbot commented May 11, 2020

Change https://golang.org/cl/233197 mentions this issue: x/crypto/acme: make Client.Register behavior consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants