Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestCancelRequestWithChannelBeforeDo_Cancel failure on Windows long test [1.13 backport] #37892

Closed
gopherbot opened this issue Mar 16, 2020 · 2 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 16, 2020

@dmitshur requested issue #35122 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13. This is a test fix. It is needed to fix resolve a failure in the net/http package on windows-amd64-longtest builder, which could be masking other problems and making releasing Go 1.13.x more difficult.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 16, 2020

Change https://golang.org/cl/223699 mentions this issue: [release-branch.go1.13] net/http: deflake TestCancelRequestWithChannelBeforeDo_Cancel

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 31, 2020

Closed by merging 7261619 to release-branch.go1.13.

@gopherbot gopherbot closed this Mar 31, 2020
gopherbot pushed a commit that referenced this issue Mar 31, 2020
…lBeforeDo_Cancel

Goroutines clean up takes longer when using deprecated CloseNotifier.

For #35122.
Fixes #37892.

Change-Id: Id820a3012b5c781ddfb294b38ee3b009624e398c
Reviewed-on: https://go-review.googlesource.com/c/go/+/204661
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 1e4a358)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223699
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.