Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: clarify details of executeCommand #37893

Closed
stamblerre opened this issue Mar 17, 2020 · 1 comment
Closed

x/tools/gopls: clarify details of executeCommand #37893

stamblerre opened this issue Mar 17, 2020 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Mar 17, 2020

Two key things to consider:

  1. Naming convention for commands and constants for tracking these names across the codebase
  2. Making it clear that commands operate only on saved files (if we add commands that handle overlays we can address this, but for now, using snapshots in commands doesn't make a lot of sense)
  3. Explore how the run commands without adding them to the VS Code Go extension
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Sep 9, 2020

I believe that all of these questions have been resolved. Naming will be addressed as part of #41187.

@stamblerre stamblerre closed this Sep 9, 2020
gopls: on by default in vscode-go automation moved this from Maybe to Closed Sep 9, 2020
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.0 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.