Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: -d=checkptr should not reject unaligned pointers to non-pointer data [1.14 backport] #37905

Closed
gopherbot opened this issue Mar 17, 2020 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 17, 2020

@cagedmantis requested issue #37298 to be considered for backport to the next 1.14 minor release.

@gopherbot please open a backport issue to 1.14.1

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 17, 2020

Change https://golang.org/cl/223749 mentions this issue: runtime: don't report a pointer alignment error for pointer-free base type

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Mar 17, 2020

This cherry-pick is approved, as it is a serious issue without a workaround.

gopherbot pushed a commit that referenced this issue Mar 18, 2020
…or for pointer-free base type

Fixes #37905

Change-Id: I8ba9c8b106e16cea7dd25473c7390b0f2ba9a1a5
Reviewed-on: https://go-review.googlesource.com/c/go/+/223781
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/223749
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 18, 2020

Closed by merging 229247d to release-branch.go1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.