Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path/filepath: TestEvalSymlinksAboveRoot failures on macOS #37910

Open
bcmills opened this issue Mar 18, 2020 · 10 comments
Open

path/filepath: TestEvalSymlinksAboveRoot failures on macOS #37910

bcmills opened this issue Mar 18, 2020 · 10 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 18, 2020

2020-03-17T20:48:23-0eeec4f/darwin-amd64-race

--- FAIL: TestEvalSymlinksAboveRoot (0.01s)
    path_test.go:1449: EvalSymlinks("/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/../../../../../../../../../private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/b/file") = "/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/a/file"
    path_test.go:1449: EvalSymlinks("/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/../../../../../../../../../../private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/b/file") = "/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/a/file"
    path_test.go:1445: EvalSymlinks("/private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/../../../../../../../../../../../private/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/TestEvalSymlinksAboveRoot800207813/b/file") failed: lstat /private/../../../private/var: no such file or directory
FAIL
FAIL	path/filepath	0.252s

See previously #35201.
@bcmills bcmills added OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 18, 2020
@bcmills bcmills added this to the Backlog milestone Mar 18, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Mar 18, 2020

Given the general flakiness of macOS filesystems, I wouldn't be surprised if this is due to a platform bug. (But I wouldn't be entirely surprised if it's a Go bug either.)

CC @ianlancetaylor @cagedmantis

@bcmills
Copy link
Contributor Author

bcmills commented Apr 14, 2020

2020-04-13T23:27:02-5a706d1/darwin-amd64-race
2020-03-23T16:55:37-7af6a31/darwin-amd64-race
2020-03-22T11:16:34-9a2db7c/darwin-amd64-race

@bcmills
Copy link
Contributor Author

bcmills commented Apr 22, 2020

2020-04-21T20:49:34-2a2423b/darwin-amd64-race

@bcmills
Copy link
Contributor Author

bcmills commented Apr 30, 2020

2020-04-29T21:29:17-faafdf5/darwin-amd64-race
2020-04-28T18:41:07-39380e8/darwin-amd64-race

@bcmills bcmills changed the title path/filepath: TestEvalSymlinksAboveRoot failure on darwin-amd64-race builder path/filepath: TestEvalSymlinksAboveRoot failures on darwin-amd64-race builder Apr 30, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Sep 25, 2020

2020-09-25T03:59:54-2333c62/darwin-amd64-race
2020-09-17T19:18:10-35e413c/darwin-amd64-10_15
2020-09-16T17:07:38-2ae2a94/darwin-amd64-race
2020-08-18T20:05:33-30a68bf/darwin-amd64-race
2020-07-06T20:17:51-20afbe8/darwin-amd64-race
2020-06-15T23:29:23-d286e61/darwin-amd64-race
2020-06-03T16:05:37-9e56bcb/darwin-amd64-race

@bcmills
Copy link
Contributor Author

bcmills commented Nov 9, 2020

2020-11-07T22:38:01-afe7c8d/darwin-amd64-10_15
2020-11-06T23:59:04-f7ef5ca/darwin-amd64-race
2020-11-04T21:26:23-5ed81a3/darwin-amd64-race
2020-10-28T17:54:13-fc116b6/darwin-amd64-race
2020-10-27T18:23:46-e3bb53a/darwin-amd64-race
2020-10-22T18:16:29-2ad4415/darwin-amd64-10_15
2020-10-17T00:01:00-f1e3c8f/darwin-amd64-race
2020-10-13T01:16:56-85f829d/darwin-amd64-10_15
2020-10-12T17:22:19-3736957/darwin-amd64-10_15
2020-10-01T17:47:21-adef4de/darwin-amd64-race
2020-09-26T15:48:06-66fbb80/darwin-amd64-race

@bcmills bcmills changed the title path/filepath: TestEvalSymlinksAboveRoot failures on darwin-amd64-race builder path/filepath: TestEvalSymlinksAboveRoot failures on darwin-amd64 builders Nov 9, 2020
@dmitshur
Copy link
Contributor

I've run into this failure on darwin/arm64 as well, so it's not just darwin/amd64.

It seems to be quite easy to reproduce when the system is under load with:

$ go version
go version devel +7716a2fbb7 Sun Nov 22 11:44:49 2020 -0500 darwin/arm64  # CL 272258 PS 1
$ go test path/filepath -run=TestEvalSymlinksAboveRoot -count=1000
--- FAIL: TestEvalSymlinksAboveRoot (0.00s)
    path_test.go:1485: EvalSymlinks("/private/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T/TestEvalSymlinksAboveRoot880924197/../../../../../../../private/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T/TestEvalSymlinksAboveRoot880924197/b/file") = "/private/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T/TestEvalSymlinksAboveRoot880924197/a/file"
    path_test.go:1481: EvalSymlinks("/private/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T/TestEvalSymlinksAboveRoot880924197/../../../../../../../../private/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T/TestEvalSymlinksAboveRoot880924197/b/file") failed: lstat /private/../../private/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T: no such file or directory
    path_test.go:1481: EvalSymlinks("/private/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T/TestEvalSymlinksAboveRoot880924197/../../../../../../../../../private/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T/TestEvalSymlinksAboveRoot880924197/b/file") failed: lstat /private/../../../private: no such file or directory
FAIL
FAIL	path/filepath	2.797s
FAIL

But hard to reproduce when the system isn't under load.

@dmitshur dmitshur changed the title path/filepath: TestEvalSymlinksAboveRoot failures on darwin-amd64 builders path/filepath: TestEvalSymlinksAboveRoot failures on macOS Nov 23, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Feb 22, 2021

2021-02-20T03:54:48-0625460/darwin-amd64-race
2021-02-16T18:25:10-6f3da9d/darwin-amd64-race
2021-01-08T05:00:06-304f769/darwin-amd64-race
2020-12-22T20:00:00-c9fb4eb/darwin-amd64-race
2020-11-25T02:51:30-1308f11/darwin-amd64-10_15

@bcmills
Copy link
Contributor Author

bcmills commented Mar 19, 2021

2021-03-19T01:02:56-dcc96e4/darwin-arm64-11_0-toothrot
2021-03-04T03:29:58-95ff296/darwin-amd64-race
2021-02-25T15:24:25-9fe8ebf/darwin-amd64-race

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/332009 mentions this issue: path/filepath: deflake TestEvalSymlinksAboveRoot on darwin

gopherbot pushed a commit that referenced this issue Jun 30, 2021
@josharian
path/filepath: deflake TestEvalSymlinksAboveRoot on darwin
ed56ea7 
On darwin, under load, it appears that the system occasionally
deletes the temp dir mid-test. Don't fail the test when that happens.

It would be nice to fix this in a deeper way.
See golang.org/cl/332009 for some discussion.

In the meantime, this will at least stop the flakiness.

Updates #37910

Change-Id: I6669e466fed9abda4a87ca88345c04cd7986b41e
Reviewed-on: https://go-review.googlesource.com/c/go/+/332009
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot