Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/present2md: support full translation #37917

Open
johanbrandhorst opened this issue Mar 18, 2020 · 2 comments
Open

x/tools/cmd/present2md: support full translation #37917

johanbrandhorst opened this issue Mar 18, 2020 · 2 comments
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@johanbrandhorst
Copy link
Member

johanbrandhorst commented Mar 18, 2020 •
edited
Loading

Not sure this should be considered part of #33955. Please close if so.

The new present2md tool converts the present format to markdown. However, it is still missing some pieces of the present format when converting, namely:

  • Captions
  • Images

There may be more types I've missed, but these were the ones I noticed so far.

These are being caught by the fallback PresentCmd interface here:

https://github.com/golang/tools/blob/11a475a590acad44f466dde7d3e988cf52bad01c/cmd/present2md/main.go#L236-L247

I think it should be possible to convert both of these to markdown, though the caption may be more complicated.
@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Mar 18, 2020
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 18, 2020
@cagedmantis
Copy link
Contributor

/cc @ianthehat @matloob

@matloob
Copy link
Contributor

matloob commented Mar 20, 2020

/cc @rsc @bcmills @jayconrod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@cagedmantis @bcmills @johanbrandhorst @gopherbot @matloob