Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: require GetQueuedCompletionStatusEx in Windows netpoll code #37957

Closed
ianlancetaylor opened this issue Mar 20, 2020 · 4 comments
Closed

runtime: require GetQueuedCompletionStatusEx in Windows netpoll code #37957

ianlancetaylor opened this issue Mar 20, 2020 · 4 comments
Milestone

Comments

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 20, 2020

In the runtime package, on Windows, if the function GetQueuedCompletionStatusEx is not available on the system, we use the simpler but slower GetQueuedCompletionStatus function.

According to https://docs.microsoft.com/en-us/windows/win32/fileio/getqueuedcompletionstatusex-func, GetQueuedCompletionStatusEx is available on Windows Vista, Windows Server 2008, and newer.

According to https://golang.org/wiki/MinimumRequirements, as of the Go 1.11 release we require at least Windows 7, or Windows 2008R2, or higher.

According to https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions, Windows 7 is newer than Windows Vista.

Therefore, I believe that all supported Windows systems support GetQueuedCompletionStatusEx, and we can remove the code that uses GetQueuedCompletionStatus.

@alexbrainman @mattn Do you agree?

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Mar 21, 2020

@ianlancetaylor I agree. We can remove all code that calls GetQueuedCompletionStatus.

Do you want me to do the honors?

Alex

@ianlancetaylor
Copy link
Contributor Author

@ianlancetaylor ianlancetaylor commented Mar 21, 2020

(Same answer.) I can do it, unless you would like to. Thanks.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 24, 2020

Change https://golang.org/cl/225059 mentions this issue: runtime: always use GetQueuedCompletionStatusEx on Windows

@mattn
Copy link
Member

@mattn mattn commented Mar 24, 2020

I agree with you

@gopherbot gopherbot closed this in e3cf052 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.