Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: data race between parallel panicking and normal subtest [1.14 backport] #37959

Closed
gopherbot opened this issue Mar 20, 2020 · 3 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 20, 2020

@ianlancetaylor requested issue #37551 to be considered for backport to the next 1.14 minor release.

@gopherbot Please backport to 1.14. This is a regression that was newly introduced in 1.14.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 20, 2020

Change https://golang.org/cl/224257 mentions this issue: [release-branch.go1.14] testing: fix data race between parallel subtests

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Mar 20, 2020

Approved. It's a regression in 1.14 without a known workaround.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 20, 2020

Closed by merging ab9d037 to release-branch.go1.14.

@gopherbot gopherbot closed this Mar 20, 2020
gopherbot pushed a commit that referenced this issue Mar 20, 2020
This CL fixes a race condition if there are two subtests, and
one finishing but the other is panicking.

For #37551
Fixes #37959

Change-Id: Ic33963eb338aec228964b95f7c34a0d207b91e00
Reviewed-on: https://go-review.googlesource.com/c/go/+/221322
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 93a9561)
Reviewed-on: https://go-review.googlesource.com/c/go/+/224257
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Changkun Ou <euryugasaki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.