Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/dashboard: atLeastGo1/atMostGo1 helpers handle non-release branches incorrectly #37965

dmitshur opened this issue Mar 20, 2020 · 0 comments


Copy link

@dmitshur dmitshur commented Mar 20, 2020

As a follow-up to #37953, we can improve the atLeastGo1 and atMostGo1 helpers so that they operate closer to what the name suggests, and report only whether the Go version meets a certain number. Right now they report suboptimal results on non-release branches in some situations.

For example, the master branch is currently where Go 1.15 is being developed, but atLeastGo1(goBranch, 16) reports true. It should be false.

Similarly, atMostGo1(goBranch, 15) makes an incorrect assumption that master is already greater than 1.15, and reports false. It should be true.

cmd/coordinator can look up precise Go release information (via maintnerClient), and use it to make a better decision. We'll need to modify the signature of BuildsRepoPostSubmit to pass more information to it.

/cc @toothrot @cagedmantis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant