Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: "pipe failed with -89" at program startup(mipsle only), timer related netpoll init. [1.14 backport] #38005

Closed
gopherbot opened this issue Mar 22, 2020 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 22, 2020

@ianlancetaylor requested issue #37997 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open backport for 1.14.

This is a fatal crash with no workaround on mips systems running Linux kernels that do not support pipe2.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 25, 2020

This is a fatal crash on MIPS systems that do not have the pipe2 system call. Cherry pick approved.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 25, 2020

Change https://golang.org/cl/225419 mentions this issue: [release-branch.go1.14] runtime: negate errno value for mips pipe/pipe2

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 25, 2020

Closed by merging 21f453b to release-branch.go1.14.

@gopherbot gopherbot closed this Mar 25, 2020
gopherbot pushed a commit that referenced this issue Mar 25, 2020
The callers expect negative errno values, so negate them when necessary.

No test because there is no reasonable way to make pipe/pipe2 fail.
This was reported on a system on which pipe2 returned ENOSYS.

For #37997
Fixes #38005

Change-Id: I3ad6cbbc2521cf495f8df6ec991a3f781122b508
Reviewed-on: https://go-review.googlesource.com/c/go/+/224592
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
(cherry picked from commit 20b46c7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/225419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.