Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: tests are slow #38007

rasky opened this issue Mar 22, 2020 · 2 comments

runtime: tests are slow #38007

rasky opened this issue Mar 22, 2020 · 2 comments


Copy link

@rasky rasky commented Mar 22, 2020

Runtime tests are the slowest on my laptop, and contribute in a non trivial way to the total time of all.bash. go test -v runtime takes 169s (tip, darwin/amd64).

These are all tests that take more than 1 second:

--- PASS: TestChanSendSelectBarrier (7.20s)
--- PASS: TestChanSendBarrier (6.55s)
--- PASS: TestCgoSignalDeadlock (5.70s)
--- PASS: TestFastLog2 (4.81s)
--- PASS: TestSmhasherSmallKeys (6.61s)
--- PASS: TestSmhasherZeros (1.46s)
--- PASS: TestSmhasherTwoNonzero (17.23s)
--- PASS: TestSmhasherCyclic (3.46s)
--- PASS: TestSmhasherSparse (8.27s)
--- PASS: TestSmhasherPermutation (19.04s)
--- PASS: TestSmhasherAvalanche (19.62s)
--- PASS: TestSmhasherWindowed (22.87s)
--- PASS: TestSmhasherText (5.04s)
--- PASS: TestCollisions (1.29s)
--- PASS: TestAsyncPreempt (1.05s)
--- PASS: TestSchedLocalQueueEmpty (1.29s)
--- PASS: TestPreemptionAfterSyscall (1.01s)
--- PASS: TestGoroutineProfile (1.11s)
--- PASS: TestStackMem (3.57s)
--- PASS: TestStackGrowth (2.54s)
--- PASS: TestDeferHeapAndStack (4.02s)
--- PASS: TestCgoNumGoroutine (6.81s)
--- PASS: TestCgoTracebackContext (6.81s)
--- PASS: TestCgoCrashTraceback (6.80s)
--- PASS: TestDeferKeepAlive (1.04s)
--- PASS: TestCgoCCodeSIGPROF (1.24s)
--- PASS: TestMemmoveAlias (2.60s)
--- PASS: TestMemmoveLarge0x180000 (4.03s)
--- PASS: TestMemmove (1.66s)
--- PASS: TestMemmoveOverlapLarge0x120000 (6.99s)
--- PASS: TestCgoExternalThreadSignal (6.69s)
--- PASS: TestCgoExternalThreadSIGPROF (4.01s)
--- PASS: TestVDSO (1.15s)
--- PASS: TestFakeTime (2.49s)

I think it would be great to look into them and try to reduce them.

Copy link

@ianlancetaylor ianlancetaylor commented Mar 22, 2020

Is this with or without -test.short? Note that all.bash and run.bash use -test.short.

Copy link
Member Author

@rasky rasky commented Mar 22, 2020

Ah you're right. Let me close this, maybe I'll open a different one then.

@rasky rasky closed this as completed Mar 22, 2020
@golang golang locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

No branches or pull requests

3 participants