Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support change signature refactoring #38028

stamblerre opened this issue Mar 23, 2020 · 3 comments

x/tools/gopls: support change signature refactoring #38028

stamblerre opened this issue Mar 23, 2020 · 3 comments
FeatureRequest gopls Tools


Copy link

@stamblerre stamblerre commented Mar 23, 2020

See microsoft/vscode-go#3122 for the original request.

Is your feature request related to a problem? Please describe.
I use IntelliJ and VS Code - both for development. VS Code usually for my open source contributions. I noticed that IntelliJ has this cool feature to change the definition / signature of a method or a function - where one can change the parameter's type, add a parameter with a default value for all the callers, and change the return parameters too

Describe the solution you'd like
VS Code to provide the feature to change the definition / signature of a method or function, which changes all the references of the method or function based on the change

Describe alternatives you've considered
Some features of the change signature feature can still be used currently - For example changing the name of the parameters - which will only cause a change inside the method or function and it can be done by doing just a rename. Other than that, the only alternate solution for me now is - to find all the references and change all the callers to add a parameter and do something similar for other things too.

Additional context
It would be cool for VS code to provide this feature. Not sure how it will be implemented. Is this a feature that should be provided by gopls? And if help is needed, I can pitch in - raise some PRs. I need to learn some stuff, which I can surely do. It would be a pleasure to raise PR for one of the greatest extensions for Golang 😄

@stamblerre stamblerre added FeatureRequest gopls Tools labels Mar 23, 2020
@gopherbot gopherbot added this to the Unreleased milestone Mar 23, 2020
Copy link
Contributor Author

@stamblerre stamblerre commented Jun 5, 2020

We could also use change signature as a suggested fix for the fillreturns analyzer.

/cc @joshbaum

@stamblerre stamblerre removed this from the Unreleased milestone Jul 23, 2020
Copy link

@underscorenico underscorenico commented Sep 9, 2020

I would greatly appreciate this feature! thanks for your work on gopls by the way 🙂

@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
Copy link

@goblinfactory goblinfactory commented Sep 3, 2021

Hi guys ...any news on this feature?
Given that GO doesnt have method overloads, this is a super critical need, since you cannot get away with search and replace to make these refactorings with a text editor/grep etc. Seems a bit overkill to have 1 person in the dev team manage all method refactorings with a single goland licence.

This thread looks dead, (no movement since October 2020) does this mean that as a noobie GOLANG user I've missed something (obvious to the wise grey haired folk) that makes this a non issue?

please advise...txs, Alan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
FeatureRequest gopls Tools
None yet

No branches or pull requests

4 participants