Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: linux-amd64-staticlockranking consistently failing #38029

Closed
andybons opened this issue Mar 23, 2020 · 7 comments
Closed

x/build: linux-amd64-staticlockranking consistently failing #38029

andybons opened this issue Mar 23, 2020 · 7 comments

Comments

@andybons
Copy link
Member

@andybons andybons commented Mar 23, 2020

@danscales will golang.org/cl/207619 fix this?

linux-amd64-staticlockranking at 8c30971da654a37a5f5f211e6dccf8d83e7ee463

:: Running /workdir/go/src/make.bash with args ["/workdir/go/src/make.bash"] and env ["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn3d0c937" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=24.1s" "GO_STAGE0_DL_DELAY=100ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64-staticlockranking" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOEXPERIMENT=staticlockranking" "GOBIN=" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/go/src

Building Go cmd/dist using /go1.4. (go1.4 linux/amd64)
Building Go toolchain1 using /go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
unknown experiment staticlockranking

go tool dist: FAILED: /workdir/go/pkg/tool/linux_amd64/asm -I /workdir/tmp/go-tool-dist-034385281/internal/cpu -I /workdir/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -D GOOS_GOARCH_linux_amd64 -gensymabis -o /workdir/tmp/go-tool-dist-034385281/internal/cpu/symabis /workdir/go/src/internal/cpu/cpu_x86.s: exit status 2
unknown experiment staticlockranking

go tool dist: FAILED: /workdir/go/pkg/tool/linux_amd64/compile -std -pack -o /workdir/tmp/go-tool-dist-034385281/runtime/internal/sys/_go_.a -p runtime/internal/sys -importcfg /workdir/tmp/go-tool-dist-034385281/runtime/internal/sys/importcfg /workdir/go/src/runtime/internal/sys/arch.go /workdir/go/src/runtime/internal/sys/arch_amd64.go /workdir/go/src/runtime/internal/sys/intrinsics.go /workdir/go/src/runtime/internal/sys/intrinsics_common.go /workdir/go/src/runtime/internal/sys/stubs.go /workdir/go/src/runtime/internal/sys/sys.go /workdir/go/src/runtime/internal/sys/zgoarch_amd64.go /workdir/go/src/runtime/internal/sys/zgoos_linux.go /workdir/go/src/runtime/internal/sys/zversion.go: exit status 2
go tool dist: open /workdir/tmp/go-tool-dist-034385281/internal/cpu/_go_.a: no such file or directory
go tool dist: open /workdir/tmp/go-tool-dist-034385281/runtime/internal/sys/_go_.a: no such file or directory
go tool dist: open /workdir/tmp/go-tool-dist-034385281/runtime/internal/atomic/_go_.a: no such file or directory
unknown experiment staticlockranking

go tool dist: FAILED: /workdir/go/pkg/tool/linux_amd64/asm -I /workdir/tmp/go-tool-dist-034385281/runtime/internal/atomic -I /workdir/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -D GOOS_GOARCH_linux_amd64 -gensymabis -o /workdir/tmp/go-tool-dist-034385281/runtime/internal/atomic/symabis /workdir/go/src/runtime/internal/atomic/asm_amd64.s: exit status 2
@danscales
Copy link

@danscales danscales commented Mar 23, 2020

Yes, I need to check in https://go-review.googlesource.com/c/go/+/222925 (probably go in today) and https://go-review.googlesource.com/c/go/+/207619 (probably submit in another couple of days).

I'm not quite sure why @dmitshur enabled the builder before my checkins went in. Feel free to disable until my second checkin goes in -- whatever makes sense.

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Mar 23, 2020

@andybons The failure is expected. See #37937 for context.

I enabled the builder a few days in advance of it being needed so that it would be available for SlowBots at the time the CL is ready, and so that it would start running when the relevant CL lands. This is consistent with the protocol for adding new builders in https://golang.org/wiki/PortingPolicy:

The builder must already be running (and failing, because the code is not yet in the main repository).

Maybe we need to improve the UI in build.golang.org to mark "this builder is known to not be passing yet; see tracking issue nnn".

Loading

@andybons
Copy link
Member Author

@andybons andybons commented Mar 23, 2020

@dmitshur thanks for the context. Will leave open anyway to track. @danscales can you add this issue to a Fixes line on the CL that will make the builder go green? Thank you!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 24, 2020

Change https://golang.org/cl/207619 mentions this issue: runtime: static lock ranking for the runtime (enabled by GOEXPERIMENT)

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 6, 2020

Change https://golang.org/cl/227379 mentions this issue: dashboard, app/appengine: set a known issue for staticlockranking builder

Loading

gopherbot pushed a commit to golang/build that referenced this issue Apr 7, 2020
…lder

The linux-amd64-staticlockranking builder was added pre-emptively so
that it could be tested and used during the development of a CL that
implements a new feature. It's expected to fail until that work is
completed. Mark it as a builder with a known issue, golang/go#38029.

The new BuildConfig.KnownIssue field can be used by builders being
added in the future so that if they fail at first, it doesn't take
away time for people looking at build.golang.org, which we always
aim to have as green as possible¹.

¹ https://groups.google.com/d/msg/golang-dev/y0yM_Xi665Q/hUpBiUPiCAAJ

Fixes golang/go#38283
For golang/go#38029
For golang/go#37937
For golang/go#11811

Change-Id: Iba1606c7021ffa7e67ddbaae2fc6b65f4e46ab34
Reviewed-on: https://go-review.googlesource.com/c/build/+/227379
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@gopherbot gopherbot closed this in 0a82000 Apr 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 8, 2020

Change https://golang.org/cl/227544 mentions this issue: dashboard: unset known issue for staticlockranking builder

Loading

gopherbot pushed a commit to golang/build that referenced this issue Apr 8, 2020
CL 207619 has been submitted to master, fixing golang.org/issue/38029.
The linux-amd64-staticlockranking builder has been passing since then.
Unset its known issue so that if there are regressions in the future,
they can be investigated.

For golang/go#38029.
For golang/go#37937.

Change-Id: I0de8e4ac122effee56aac73c741fab41512ff0c2
Reviewed-on: https://go-review.googlesource.com/c/build/+/227544
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 24, 2020

Change https://golang.org/cl/244631 mentions this issue: runtime, sync: add copyright headers to new files

Loading

gopherbot pushed a commit that referenced this issue Jul 25, 2020
For #38029

Change-Id: I71de2b66c1de617d32c46d4f2c1866f9ff1756ec
Reviewed-on: https://go-review.googlesource.com/c/go/+/244631
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants