Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/ecdsa: builders with long tests are failing in crypto/ecdsa.TestEqual #38035

Closed
danscales opened this issue Mar 23, 2020 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@danscales
Copy link

@danscales danscales commented Mar 23, 2020

The builders with long tests (GO_TEST_SHORT=0) are failing in crypto.dsa.TestEqual. For example:

https://build.golang.org/log/eaeb045adcbf56e2df980dc0cb8c17554dc2b50a

Looks like it started happening with change 5c9bd49, https://go-review.googlesource.com/c/go/+/223754 @FiloSottile

What version of Go are you using (go version)?

Running on current gc tip

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Happens on linux-amd64 and bunch of other architectures.

@FiloSottile FiloSottile changed the title crypto/dsa: builders with long tests are failing in crypto/dsa.TestEqual crypto/ecdsa: builders with long tests are failing in crypto/ecdsa.TestEqual Mar 23, 2020
@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented Mar 23, 2020

Reverted in CL 225077. I know what to fix.

@FiloSottile FiloSottile self-assigned this Mar 23, 2020
@FiloSottile FiloSottile added this to the Go1.15 milestone Mar 23, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Mar 25, 2020

Change https://golang.org/cl/225460 mentions this issue: crypto/rsa,crypto/ecdsa,crypto/ed25519: implement PublicKey.Equal

@gopherbot gopherbot closed this in b5f2c0f Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.