Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: invoking `go version` causes a crash on Windows #38062

Closed
inliquid opened this issue Mar 25, 2020 · 4 comments
Closed

x/tools/gopls: invoking `go version` causes a crash on Windows #38062

inliquid opened this issue Mar 25, 2020 · 4 comments
Labels
Milestone

Comments

@inliquid
Copy link

@inliquid inliquid commented Mar 25, 2020

  1. go1.14
  2. VS Code

Today, after upgrade to latest from master, gopls started to crash with the error:
panic: err: exit status 1: stderr: go: creating work dir: mkdir C:\Windows\go-build728148707: Access is denied.

Previous version was compiled smth like ~1-2 days ago, so it's recent change.

C:\Users\***>echo %TMP%
C:\Users\***\AppData\Local\Temp

C:\Users\***>echo %TEMP%
C:\Users\***\AppData\Local\Temp
@gopherbot gopherbot added this to the Unreleased milestone Mar 25, 2020
@golang golang deleted a comment from gopherbot Mar 25, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.4.0 Mar 25, 2020
@stamblerre stamblerre changed the title x/tools/gopls: recent change make gopls crash on Windows x/tools/gopls: invoking `go version` causes a crash on Windows Mar 25, 2020
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Mar 25, 2020

Thanks for the report! I am able to reproduce the crash on Windows. It's caused by https://golang.org/cl/225137 - specifically by calling go version in golang.org/x/tools/internal/lsp/debug/info.go. Probably we have to set a different working directory for the command? I'll take a look today.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 27, 2020

Change https://golang.org/cl/225817 mentions this issue: internal/gocommand: only set working dir if it's not empty

@inliquid
Copy link
Author

@inliquid inliquid commented Mar 29, 2020

Problem is still there...

@stamblerre stamblerre reopened this Mar 30, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 30, 2020

Change https://golang.org/cl/226370 mentions this issue: internal/gocommand: fix environment on Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.