Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: create version CL via Gerrit API instead of filesystem+git+codereview #38075

Open
dmitshur opened this issue Mar 25, 2020 · 0 comments
Assignees
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 25, 2020

During most release types (all other than beta), releasebot needs to create a Gerrit CL that update the content of the VERSION file. For a recent example, see CL 223923.

The current implementation is in a writeVersion method. It relies on having a Git checkout of the Go repository in a "gitwork" directory on disk, writing the VERSION file, having configured git and git-codereview commands with authentication info (typically, that of the release operator).

It appears to be possible to create that CL by using the Gerrit REST API, specifically using the Create Change and Change Edit endpoints. There are Gerrit API Go clients available in golang.org/x/build/gerrit and github.com/andygrunwald/go-gerrit packages.

Doing this will reduce dependence on having a writeable filesystem, configured git and git-codereview tools, and can be used for further automation of releases in the future.

/cc @toothrot @cagedmantis @andybons

@dmitshur dmitshur added this to the Unreleased milestone Mar 25, 2020
@dmitshur dmitshur self-assigned this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.