Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/dashboard: macOS builders should specify filesystem case sensitivity in Notes field #38076

Closed
dmitshur opened this issue Mar 25, 2020 · 4 comments
Assignees
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 25, 2020

It should be easy to find out whether the filesystem is case sensitive or insensitive (macOS offers both options).

We can put this information in the Notes field, so it'll show up at https://farmer.golang.org/builders.

/cc @cagedmantis @toothrot @heschik

@dmitshur dmitshur added this to the Unreleased milestone Mar 25, 2020
@cagedmantis cagedmantis self-assigned this Mar 25, 2020
@andybons
Copy link
Member

@andybons andybons commented Mar 25, 2020

I think it should only be noted if it is not the default configuration for macOS (this applies for any builder configuration, really). I don’t see this configuration value being worthy enough to call out specifically.

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Mar 25, 2020

When writing up this issue, I also initially hesitated about suggesting using the Notes field, because I noticed all the linux builders don't specify it either.

However, the main point of this issue is:

It should be easy to find out whether the filesystem is case sensitive or insensitive (macOS offers both options).

When I had to look this up recently, I first checked https://farmer.golang.org/builders, then https://github.com/golang/build/tree/master/env/darwin/macstadium, then some internal documents, and couldn't find an answer. The only reliable way to confirm an answer was to gomote into a builder, as @cagedmantis has done.

I don't mind too much whether this information is placed in Notes or elsewhere, but I think it should be easy to look up an answer to this question more quickly in the future. The filesystem case sensitivity is a configurable option when installing macOS, so it's not easy to have complete confidence about what the default on macOS builders is.

@andybons Do you think it'd be better to document this somewhere else, or should we just rely on gomote to look up an answer in the future if we need to again?

@andybons
Copy link
Member

@andybons andybons commented Mar 25, 2020

Do you think it'd be better to document this somewhere else, or should we just rely on gomote to look up an answer in the future if we need to again?

How many users have reported issues that are related to case-insensitivity? What is the default behavior when installing macOS? We should assume, and document otherwise, that our builders were installed with the default setting for any option.

If there is a need to find out what the behavior is, then gomoting is the right answer in this case. We should only be documenting behavior that is outside the norm for a particular OS/platform/VM.

@andybons
Copy link
Member

@andybons andybons commented Mar 26, 2020

Closing per discussion with @dmitshur outside of this issue.

@andybons andybons closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.