Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: remove ellipses from test names #38103

Closed
stamblerre opened this issue Mar 27, 2020 · 1 comment
Closed

x/tools/gopls: remove ellipses from test names #38103

stamblerre opened this issue Mar 27, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Mar 27, 2020

Our test names seem to have ... in them, for example: TestSource/Modules/../testdata/lsp/References/refs_33_8/refs-declaration-false. This makes them a little bit difficult to work with. I believe this happened as a result of @ridersofrohan's changes to go/packages/packagestest. @ridersofrohan: Would it be possible to remove the ellipses from the test names?

@stamblerre stamblerre added this to the gopls/v0.4.0 milestone Mar 27, 2020
@ridersofrohan ridersofrohan self-assigned this Mar 30, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 30, 2020

Change https://golang.org/cl/226377 mentions this issue: internal/lsp/tests: remove ellipses from test names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.