Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/asm: update where NOFRAME is valid #38110

Open
randall77 opened this issue Mar 27, 2020 · 4 comments
Open

cmd/asm: update where NOFRAME is valid #38110

randall77 opened this issue Mar 27, 2020 · 4 comments

Comments

@randall77
Copy link
Contributor

@randall77 randall77 commented Mar 27, 2020

The current comment for NOFRAME in runtime/textflag.h says:

// TODO(mwhudson): only implemented for ppc64x at present.

It's been implemented for lots (all?) architectures since.
Check our coverage and update (delete) this comment.

@mwhudson @zhangfannie

@randall77 randall77 added this to the Unplanned milestone Mar 27, 2020
@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Mar 27, 2020

Yeah, I think it is implemented in nearly all architectures. If I remember correctly, @aclements did that.

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Mar 27, 2020

@andybons andybons added the NeedsFix label Mar 27, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 29, 2020

Change https://golang.org/cl/226284 mentions this issue: runtime: remove TODO comment about NOFRAME, now done

@mwhudson
Copy link
Contributor

@mwhudson mwhudson commented Mar 29, 2020

Oh yay, glad that got done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.