Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestIdentityResponse is flaky on slow builders #38112

bcmills opened this issue Mar 27, 2020 · 1 comment

net/http: TestIdentityResponse is flaky on slow builders #38112

bcmills opened this issue Mar 27, 2020 · 1 comment


Copy link

@bcmills bcmills commented Mar 27, 2020


--- FAIL: TestIdentityResponse (2.08s)
    serve_test.go:3636: Timeout expired after 2s
FAIL	net/http	14.459s

It's not obvious to me why this test has a timeout at all: if the call hangs, letting the test die (and dump stacks for the hung goroutines) seems strictly more useful than a "Timeout expired" error without stacks.

@bcmills bcmills added this to the Go1.15 milestone Mar 27, 2020
@bcmills bcmills self-assigned this Mar 27, 2020
Copy link

@gopherbot gopherbot commented Mar 27, 2020

Change mentions this issue: net/http: remove arbitrary timeouts from TestIdentityResponse and TestTLSHandshakeTimeout

@gopherbot gopherbot closed this in a5d1a9d Mar 27, 2020
@golang golang locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants