Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestIdentityResponse is flaky on slow builders #38112

Closed
bcmills opened this issue Mar 27, 2020 · 1 comment
Closed

net/http: TestIdentityResponse is flaky on slow builders #38112

bcmills opened this issue Mar 27, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Mar 27, 2020

2020-03-26T14:23:17-f9c5ef8/solaris-amd64-oraclerel
2020-02-07T18:04:09-c7c525a/plan9-386-0intro

--- FAIL: TestIdentityResponse (2.08s)
    serve_test.go:3636: Timeout expired after 2s
FAIL
FAIL	net/http	14.459s

It's not obvious to me why this test has a timeout at all: if the call hangs, letting the test die (and dump stacks for the hung goroutines) seems strictly more useful than a "Timeout expired" error without stacks.

@bcmills bcmills added this to the Go1.15 milestone Mar 27, 2020
@bcmills bcmills self-assigned this Mar 27, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 27, 2020

Change https://golang.org/cl/225977 mentions this issue: net/http: remove arbitrary timeouts from TestIdentityResponse and TestTLSHandshakeTimeout

@gopherbot gopherbot closed this in a5d1a9d Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.