Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: conversion from int/float typed constant to complex variable changed in 1.14 [1.13 backport] #38122

Closed
gopherbot opened this issue Mar 28, 2020 · 2 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 28, 2020

@ianlancetaylor requested issue #38117 to be considered for backport to the next 1.13 minor release.

Looks like we're going back to the 1.13 behavior. I'll let @griesemer review the CL, but:

@gopherbot Please open a backport to 1.14.

The compiler behavior changed the way it handles constant conversions. This can break existing programs with no workaround other than rewriting the program, which should not be needed.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 28, 2020

We only need a backport to 1.14, and I only asked for a backport to 1.14, not sure why gopherbot opened this issue for 1.13.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 28, 2020

Oh, I see, it's because I mentioned 1.13 in the comment separately from the gopherbot request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.