Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: TestWaitGroupMisuse2 is flaky #38163

Open
bcmills opened this issue Mar 30, 2020 · 3 comments
Open

sync: TestWaitGroupMisuse2 is flaky #38163

bcmills opened this issue Mar 30, 2020 · 3 comments

Comments

@bcmills bcmills added this to the Backlog milestone Mar 30, 2020
@mundaym
Copy link
Member

@mundaym mundaym commented Jul 17, 2020

I propose that we just delete this test. It has become a time sink and I don't think there is any way to make it truly reliable. It is testing a race condition between two pieces of code that is fundamentally impossible to guarantee, especially on a VM where the underlying hardware is oversubscribed. The error condition detection that it is testing for is optional - losing it would not affect correct programs - and overlaps with the checks that -race mode does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants