Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/publicsuffix: Release as a separate module #38169

Open
tamalsaha opened this issue Mar 30, 2020 · 3 comments
Open

x/net/publicsuffix: Release as a separate module #38169

tamalsaha opened this issue Mar 30, 2020 · 3 comments

Comments

@tamalsaha
Copy link

@tamalsaha tamalsaha commented Mar 30, 2020

What did you expect to see?

Since https://github.com/golang/net/tree/master/publicsuffix includes a generated
table.go file, it will be really helpful if the publicsuffix can be made its own module. This will allow us to use the latest publicsuffix module with an old version of x/net module.

What did you see instead?

@gopherbot gopherbot added this to the Unreleased milestone Mar 30, 2020
@bcmills
Copy link
Member

@bcmills bcmills commented Apr 1, 2020

Why do you want to use an old version of x/net?

@tamalsaha
Copy link
Author

@tamalsaha tamalsaha commented Apr 1, 2020

We have a dependency on Kubernetes. We just use whatever go.mod automatically picks based on that dependency.

@bcmills
Copy link
Member

@bcmills bcmills commented Apr 3, 2020

Sure, but why is that preferable to using an upgraded x/net? (What, if any, harm does a newer x/net cause?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants