Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: go generate makes changes #38188

Closed
josharian opened this issue Mar 31, 2020 · 3 comments
Closed

runtime: go generate makes changes #38188

josharian opened this issue Mar 31, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation release-blocker Soon
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Mar 31, 2020

Some recent CL (don't know which one) causes running 'go generate' in the runtime package to make changes. Those changes cause ppc64 breakage. See CL 226679 and https://storage.googleapis.com/go-build-log/779d2501/linux-ppc64le-buildlet_c7e20015.log

I don't plan to investigate further.

cc @cherrymui @laboger

@josharian josharian added NeedsFix Soon labels Mar 31, 2020
@josharian josharian added this to the Go1.15 milestone Mar 31, 2020
@josharian josharian added NeedsInvestigation release-blocker and removed NeedsFix labels Mar 31, 2020
@cherrymui
Copy link
Member

@cherrymui cherrymui commented Mar 31, 2020

Is this new? I thought it has been like this for a long time. I always manually clean it up if I run go generate.

@josharian
Copy link
Contributor Author

@josharian josharian commented Mar 31, 2020

Maybe it's not new. I assumed it must be, since it seemed like the kind of thing that I would absolutely want to fix ASAP.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 31, 2020

Change https://golang.org/cl/226719 mentions this issue: runtime: generate dummy duffcopy

@golang golang locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation release-blocker Soon
Projects
None yet
Development

No branches or pull requests

3 participants