Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: unknown revision error doesn't propagate to diagnostics #38232

Open
stamblerre opened this issue Apr 3, 2020 · 0 comments
Open

x/tools/gopls: unknown revision error doesn't propagate to diagnostics #38232

stamblerre opened this issue Apr 3, 2020 · 0 comments
Labels
Tools gopls
Milestone
gopls/v0.5.0

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 3, 2020 •
edited

In conversation with @ardan-bkennedy, we noticed that adding a require github.com/pkg/errors v0.8.3 caused a diagnostic to get stuck because it was an unknown revision. Error messages should either get propagated, or we should clear diagnostics so they don't appear to be stuck?
@stamblerre stamblerre added this to the gopls/v0.4.0 milestone Apr 3, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.4.0, gopls/v0.5.0 Apr 3, 2020
@stamblerre stamblerre mentioned this issue May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tools gopls
Projects
None yet
Milestone
  gopls/v0.5.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot
You can’t perform that action at this time.