x/tools/gopls: unknown revision error doesn't propagate to diagnostics #38232
Milestone
Comments
Change https://golang.org/cl/242159 mentions this issue: |
Change https://golang.org/cl/242477 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jul 21, 2020
This change attempts to parse diagnostics out of `go list` error messages so that we can present them in a better way to the user. This approach is definitely tailored to the unknown revision error described in golang/go#38232, but we can modify it to handle other cases as well. Fixes golang/go#38232 Change-Id: I0b0a8c39a189a127dc36894a25614535c804a3f0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/242477 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In conversation with @ardan-bkennedy, we noticed that adding a
require github.com/pkg/errors v0.8.3
caused a diagnostic to get stuck because it was an unknown revision. Error messages should either get propagated, or we should clear diagnostics so they don't appear to be stuck?The text was updated successfully, but these errors were encountered: