Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: use telemetry library to check if completion exceeded its timeout #38277

Open
stamblerre opened this issue Apr 6, 2020 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 6, 2020

As part of debugging #38269, we've been discussing how we can indicate in tests that completion failed because of a timeout instead of a genuine failure. We don't want to return an error in this case because we still want to return whatever completion items we were able to produce before the timeout. @findleyr suggested that we could use the telemetry library for this.

/cc @ianthehat

@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 6, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 6, 2020

Change https://golang.org/cl/227340 mentions this issue: internal/lsp: remove timeout from completion tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.