Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: use telemetry library to check if completion exceeded its timeout #38277

Open
stamblerre opened this issue Apr 6, 2020 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

As part of debugging #38269, we've been discussing how we can indicate in tests that completion failed because of a timeout instead of a genuine failure. We don't want to return an error in this case because we still want to return whatever completion items we were able to produce before the timeout. @findleyr suggested that we could use the telemetry library for this.

/cc @ianthehat

@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 6, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 6, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227340 mentions this issue: internal/lsp: remove timeout from completion tests

@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jun 20, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants