Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/dashboard, x/build/app/appengine: add ability to mark builders with a known issue #38283

Closed
dmitshur opened this issue Apr 6, 2020 · 5 comments
Assignees
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Apr 6, 2020

Currently, all builder failures are displayed the same way on the build.golang.org dashboard, with a red "fail" text linking to the failure log:

image

Due to new OS versions, new ports, or new features, there are times when a builder is just being added. It is infeasible to guarantee a builder will report useful results as soon as it is added. Trying to make that the case would cause additional overhead and stress, without a good reason.

We can add a field to the dashboard.BuildConfig struct to mark builders as having a known issue and display such builders on the build.golang.org dashboard in a way that makes it easier to see that it's not a new regression that needs to be investigated anew (by many people looking at build.golang.org).

/cc @toothrot @cagedmantis @andybons @bcmills @danscales

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Apr 6, 2020

Here's what I've prototyped locally (note the linux-amd64-staticlockranking builder column displayed in gray):

image image

I realize that copying the issue number out of a tooltip isn't easy. I'm open to a suggestion how to make it better with the constraint that it shouldn't take up additional space and keeping in mind it doesn't need to be done often.

@dmitshur dmitshur added NeedsFix and removed NeedsInvestigation labels Apr 6, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 6, 2020

Change https://golang.org/cl/227379 mentions this issue: dashboard, app/appengine: set a known issue for staticlockranking builder

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Apr 6, 2020

A test version is deployed and can temporarily be seen at .... It looks like this:

image

@dmitshur dmitshur self-assigned this Apr 6, 2020
@bcmills
Copy link
Member

@bcmills bcmills commented Apr 7, 2020

I realize that copying the issue number out of a tooltip isn't easy. I'm open to a suggestion how to make it better with the constraint that it shouldn't take up additional space and keeping in mind it doesn't need to be done often.

The builder name at the top of the column isn't currently hyperlinked. Perhaps add a hyperlink from the header to the bug?

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 7, 2020

Change https://golang.org/cl/226977 mentions this issue: dashboard, env/netbsd-{amd64,386}: add NetBSD 9.0 builders

gopherbot pushed a commit to golang/build that referenced this issue Apr 7, 2020
Update NetBSD amd64 and 386 builders to the latest NetBSD 9.0 release,
using the latest versions of anita (2.3) and pkgsrc packages (2019Q4).

Also increase the image disk size from 4 GB to 16 GB. The motivation
is to help tests that require more disk space and large dependencies.
Additional adjustments to the image building script will need to be
made to make use of increased disk space for the /tmp volume, as it
is currently being mounted in RAM with size equal to 25% of memory.

Remove the manual invocation of the mozilla-rootcerts install command.
It no longer works as is in NetBSD 9.0. The mozilla-rootcerts-openssl
package is added instead, which successfully performs that same task.
Hopefully this will be a more robust approach for the future.

Continue to use an explicit URL for the NetBSD release download, and
remove unused find_latest_release.

The plan is to roll out these builders first (without trybots), gain
more confidence, enable trybots, and then remove NetBSD 8.0 builders.

For golang/go#37244.
For golang/go#30839.
For golang/go#31858.
For golang/go#31726.
For golang/go#38283.

Change-Id: Id41278eaebe64cfbcf7b1ab9bfd64e550ee0bbf1
Reviewed-on: https://go-review.googlesource.com/c/build/+/226977
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.