Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: fails to link some scheme-less URLs #38285
We use the Relaxed regex from https://github.com/mvdan/xurls to find URLs to linkify. That regex accepts URLs without schemes like
However, for at least some URLs with colons, e.g.
This seems like more of a problem with the URL parsing, than xurls per se, no? I'm happy to discuss bugs and enhancements, but I'm not sure if there are any here for me :)
As an idea, perhaps try https://golang.org/pkg/net/#SplitHostPort before https://golang.org/pkg/net/url/#Parse. That could help you support