Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: show optimization information from the compiler #38300

Closed
stamblerre opened this issue Apr 8, 2020 · 1 comment
Closed

x/tools/gopls: show optimization information from the compiler #38300

stamblerre opened this issue Apr 8, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 8, 2020

@dr2chase has recently added functionality to the compiler to produce diagnostic information about which optimizations were not performed.

gopls doesn't run the compiler, so we can't integrate this information easily, but as a starting point, we can have the user run this as a command. My thinking is that the user manually executes the command, which under the hood runs the compiler with the correct flags and publishes diagnostics with the output. The main issue is - how long should these diagnostics last? With our current architecture, the next time the user types a character, these diagnostics will automatically clear.

More information can be found on https://golang.org/cl/206658/.

@gopherbot gopherbot added this to the Unreleased milestone Apr 8, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 23, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Aug 28, 2020

This feature has been implemented as of https://golang.org/cl/243119 and will be available in gopls/v0.5.0.

@stamblerre stamblerre closed this Aug 28, 2020
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.