Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: newTrySet provides invalid goBranch value to dashboard.TryBuildersForProject when testing custom branches of golang.org/x repos #38303

Open
dmitshur opened this issue Apr 8, 2020 · 0 comments

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Apr 8, 2020

cmd/coordinator makes an assumption that is not safe to make here:

https://github.com/golang/build/blob/39561bf34556f888d43bce0ed218426494ecd88c/cmd/coordinator/coordinator.go#L1167-L1169

This is because dashboard.TryBuildersForProject may not return any builders when given a non-existing goBranch value, or it may return the wrong ones.

Spotted while reviewing CL 227397, but it's not critical to fix for #37512 because dashboard.TryBuildersForProject doesn't filter out by goBranch too aggressively at this time. Filing an issue so we don't forget.

/cc @cagedmantis @toothrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant