Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: closing a PR leaves the Gerrit CL open #38347

Closed
stamblerre opened this issue Apr 10, 2020 · 3 comments
Closed

x/build: closing a PR leaves the Gerrit CL open #38347

stamblerre opened this issue Apr 10, 2020 · 3 comments
Labels
Builders FrozenDueToAge
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 10, 2020

Another issue I noticed because of golang/tools#218. The underlying PR has been closed by the contributor, but the Gerrit CL is still open (https://golang.org/cl/225297). It would be cool if the closing of the PR would trigger the CL to be abandoned in Gerrit.
@gopherbot gopherbot added this to the Unreleased milestone Apr 10, 2020
@ALTree
Copy link
Member

@ALTree ALTree commented Apr 10, 2020

This was reported as #23850.
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Apr 10, 2020 •
edited

Ah, my bad, I should've checked. Thanks for letting me know!
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Apr 10, 2020

Duplicate of #23850
@stamblerre stamblerre marked this as a duplicate of #23850 Apr 10, 2020
@stamblerre stamblerre closed this Apr 10, 2020
@golang golang locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@ALTree @stamblerre @gopherbot