Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: undeclared types after adding new declarations in test file via git merge #38358

stamblerre opened this issue Apr 10, 2020 · 3 comments


Copy link

@stamblerre stamblerre commented Apr 10, 2020

This needs a regression test and a fix. Reported as a result of a git merge that brought in new type declarations in a new test file. This is in an in-package test, in case that matters.

Copy link

@pjweinb pjweinb commented May 18, 2020

Do we have a reproducible example of this?

Copy link
Contributor Author

@stamblerre stamblerre commented May 18, 2020

I do have a regression test in progress that we can probably build off of:

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
Copy link

@gopherbot gopherbot commented Sep 9, 2020

Change mentions this issue: gopls/internal/regtest: add a test for new symbols in test variants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.