Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: formatting on save inserts an unnecessary package clause #38412

Closed
hyangah opened this issue Apr 13, 2020 · 2 comments
Closed

x/tools/gopls: formatting on save inserts an unnecessary package clause #38412

hyangah opened this issue Apr 13, 2020 · 2 comments
Labels
Milestone

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Apr 13, 2020

When using with VS Code

settings

gopls version 0.4.0
go1.14, darwin/amd64
VS Code Go extension 0.14.0-beta.6
go extension setting: "go.useLanguageServer": true,

how to repro:

$ cat main.go
package main
func main() { }

Open the it from the code, and save the file again (command+s). That triggers text edit like:

image

Attached the gopls log. code.log

File save was requested after the message 7.
So, message 8 is the one triggered by my action.

Note: when triggering the formatting using "Format Document" (e.g. right click -> "Format Document") the formatting works as expected.

@gopherbot gopherbot added this to the Unreleased milestone Apr 13, 2020
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 13, 2020

Thanks for the report! Looks like this is caused by the codeAction (import organization). I know that it adds a fake package clause if it doesn't find one, but this doesn't seem to be that. I'll investigate.

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Apr 13, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 15, 2020

Change https://golang.org/cl/228264 mentions this issue: internal/lsp: fix imports issue with duplicate package decl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.