Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: handle deletion of a directory on disk #38422

Closed
stamblerre opened this issue Apr 13, 2020 · 1 comment
Closed

x/tools/gopls: handle deletion of a directory on disk #38422

stamblerre opened this issue Apr 13, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 13, 2020

This occurred after changing branches, causing a directory to be deleted on disk.
Diagnostics for all directories in the workspace were not propagated, leading to unreported errors.

@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 13, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre stamblerre changed the title x/tools/gopls: deleting a file on disk results in diagnostics for the nonexistent file x/tools/gopls: handle deletion of a directory on disk Oct 29, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 29, 2020

Change https://golang.org/cl/266138 mentions this issue: internal/lsp: handle deletion of a directory on disk

@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to In progress in vscode-go: gopls by default Nov 11, 2020
@stamblerre stamblerre self-assigned this Nov 19, 2020
vscode-go: gopls by default automation moved this from In progress to Done Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants