Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: adding a new test file results in no diagnostics (no metadata for package) #38423

Closed
stamblerre opened this issue Apr 13, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 13, 2020

Add regression tests and fixes for these cases. In one observed case, no diagnostics were propagated. This could be a new test package, a new x_test package, or new files in existing tests.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Nov 11, 2020

I think that this has likely already been fixed, and if not, it will be fixed in 1.16 with native go/packages overlays. Going to close this, as there is no concrete repro case.

@stamblerre stamblerre closed this Nov 11, 2020
vscode-go: gopls by default automation moved this from Needs Triage to Done Nov 11, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.