Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: adding a new test file results in no diagnostics (no metadata for package) #38423

Closed
stamblerre opened this issue Apr 13, 2020 · 1 comment
Closed

x/tools/gopls: adding a new test file results in no diagnostics (no metadata for package) #38423

stamblerre opened this issue Apr 13, 2020 · 1 comment
Labels
NeedsInvestigation Tools gopls

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 13, 2020 •
edited

Add regression tests and fixes for these cases. In one observed case, no diagnostics were propagated. This could be a new test package, a new x_test package, or new files in existing tests.
@gopherbot gopherbot added this to the Unreleased milestone Apr 13, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Apr 13, 2020
This was referenced May 5, 2020
Closed
Closed
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre stamblerre mentioned this issue Aug 28, 2020
Closed
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to Needs Triage in vscode-go: gopls by default Nov 11, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Nov 11, 2020

I think that this has likely already been fixed, and if not, it will be fixed in 1.16 with native go/packages overlays. Going to close this, as there is no concrete repro case.
@stamblerre stamblerre closed this Nov 11, 2020
vscode-go: gopls by default automation moved this from Needs Triage to Done Nov 11, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Tools gopls
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot
You can’t perform that action at this time.