Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: hyperlink does not inherit version #38429

Closed
tatsuhiro-t opened this issue Apr 14, 2020 · 1 comment
Closed

x/pkgsite: hyperlink does not inherit version #38429

tatsuhiro-t opened this issue Apr 14, 2020 · 1 comment
Assignees
Labels

Comments

@tatsuhiro-t
Copy link

@tatsuhiro-t tatsuhiro-t commented Apr 14, 2020

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

Browse versioned go.dev page:

https://pkg.go.dev/k8s.io/client-go@v0.18.1/kubernetes?tab=doc#Clientset.AdmissionregistrationV1

Check the hyperlink generated for admissionregistrationv1.AdmissionregistrationV1Interface

What did you expect to see?

The hyperlink should be https://pkg.go.dev/k8s.io/client-go@v0.18.1/kubernetes/typed/admissionregistration/v1?tab=doc#AdmissionregistrationV1Interface

What did you see instead?

The wrong hyperlink:

https://pkg.go.dev/k8s.io/client-go/kubernetes/typed/admissionregistration/v1?tab=doc#AdmissionregistrationV1Interface

@gopherbot gopherbot added this to the Unreleased milestone Apr 14, 2020
@gopherbot gopherbot added the pkgsite label Apr 14, 2020
@julieqiu julieqiu added the NeedsFix label Apr 20, 2020
@julieqiu julieqiu changed the title go.dev: Hyperlink does not inherit version x/pkgsite: Hyperlink does not inherit version Jun 15, 2020
@julieqiu julieqiu changed the title x/pkgsite: Hyperlink does not inherit version x/pkgsite: hyperlink does not inherit version Jun 15, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 9, 2020

Change https://golang.org/cl/241818 mentions this issue: internal/fetch: add versioning for import packages from same module

@shaqque shaqque self-assigned this Jul 9, 2020
@shaqque shaqque removed the help wanted label Jul 9, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/dochtml Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants