Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: remove unused funcAllocInfo struct #38456

Closed
AlphaHot opened this issue Apr 15, 2020 · 3 comments
Closed

cmd/link: remove unused funcAllocInfo struct #38456

AlphaHot opened this issue Apr 15, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@AlphaHot
Copy link

@AlphaHot AlphaHot commented Apr 15, 2020

// funcAllocInfo records totals/counts for all functions in an objfile;
// used to help with bulk allocation of sym.Symbol sub-objects.
type funcAllocInfo struct {
symPtr uint32 // number of *sym.Symbol's needed in file slices
inlCall uint32 // number of sym.InlinedCall's needed in inltree slices
pcData uint32 // number of sym.Pcdata's needed in pdata slices
fdOff uint32 // number of int64's needed in all Funcdataoff slices
}

@andybons
Copy link
Member

@andybons andybons commented Apr 15, 2020

@andybons andybons added this to the Unplanned milestone Apr 15, 2020
@thanm thanm self-assigned this Apr 15, 2020
@thanm
Copy link
Member

@thanm thanm commented Apr 15, 2020

Thanks, I'll send a CL.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 15, 2020

Change https://golang.org/cl/228318 mentions this issue: [dev.link] cmd/link/internal/loader: remove some unused types

gopherbot pushed a commit that referenced this issue Apr 15, 2020
The types funcAllocInfo and funcInfoSym are no longer referenced.

Fixes #38456.

Change-Id: Icd32445f6027429f4a2781554d2086790ebe5daf
Reviewed-on: https://go-review.googlesource.com/c/go/+/228318
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@thanm thanm closed this Apr 15, 2020
xujianhai666 added a commit to xujianhai666/go-1 that referenced this issue May 21, 2020
The types funcAllocInfo and funcInfoSym are no longer referenced.

Fixes golang#38456.

Change-Id: Icd32445f6027429f4a2781554d2086790ebe5daf
Reviewed-on: https://go-review.googlesource.com/c/go/+/228318
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.