Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: make sure gopls works without network connection #38462

Open
stamblerre opened this issue Apr 15, 2020 · 2 comments
Open

x/tools/gopls: make sure gopls works without network connection #38462

stamblerre opened this issue Apr 15, 2020 · 2 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 15, 2020

A few reports of issues with gopls when the user has no internet (one on Slack, one on microsoft/vscode-go#3105).

I wonder if there is a way we can have a regression test this - maybe by configuring something in the environment? @findleyr

@findleyr
Copy link
Contributor

@findleyr findleyr commented Apr 15, 2020

Following https://golang.org/cl/228235, the regtests use a proxy within our control. If we have examples of how gopls breaks without a network connection, we should be able to reproduce.

@mingoal
Copy link

@mingoal mingoal commented Apr 15, 2020

@findleyr
suggest scenario:
in go file, include one package which has no local cache,

  1. without network connection, will gopls hang or not?
  2. with network connection which requires http proxy, will gopls hang or not?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.