Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: confusion between "don't need bounds checks" and "don't need nil checks" #38496

Closed
josharian opened this issue Apr 17, 2020 · 2 comments

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Apr 17, 2020

CL 228106 introduced a bug. CL 228677 fixed it. See those two CLs for details. This issue exists to obtain an issue number for a test to ensure that it remains fixed.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 17, 2020

Change https://golang.org/cl/228698 mentions this issue: test: add test for nil check / bounds check compiler confusion

@gopherbot gopherbot closed this in 29d925d Apr 17, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 17, 2020

Change https://golang.org/cl/228787 mentions this issue: cmd/compile: clarify Node.NonNil and Node.Bounded

gopherbot pushed a commit that referenced this issue Apr 20, 2020
Node.NonNil and Node.Bounded were a bit muddled. This led to #38496.
This change clarifies and documents them.

It also corrects one misuse.
However, since ssa conversion doesn't make full use of the bounded hint,
this correction doesn't change any generated code.
The next change will fix that.

Passes toolstash-check.

Change-Id: I2bcd487a0a4aef5d7f6090e653974fce0dce3b8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/228787
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.