Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: deleted files are being treated like orphaned files #38498

Closed
stamblerre opened this issue Apr 17, 2020 · 4 comments
Closed

x/tools/gopls: deleted files are being treated like orphaned files #38498

stamblerre opened this issue Apr 17, 2020 · 4 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 17, 2020

Repro: Create and delete a package with one Go file in it. The logs will contain packages.Loads for this file that no longer exists, causing a huge slowdown. Somehow it never gets marked as "unloadable".

@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 17, 2020
@heschik
Copy link
Contributor

@heschik heschik commented Jun 16, 2020

I can't reproduce this, at least not after https://golang.org/cl/238028.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jun 25, 2020

Neither can I. Closing.

@stamblerre stamblerre closed this Jun 25, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.4 Jul 9, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jul 16, 2020

Reopening - I just had this happen to me. I deleted a file through the VS Code interface, and then immediately began experiencing a slowdown (laggy diagnostics). Looking at the logs, we were still constantly reloading the file and getting 0 packages for it.

@stamblerre stamblerre reopened this Jul 16, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 16, 2020

Change https://golang.org/cl/242924 mentions this issue: internal/lsp: don't keep track of closed overlays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.