Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: can preempt running G asynchronously by sending sigurg while asyncpreemptoff is set #38531

Closed
koushki opened this issue Apr 19, 2020 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation
Milestone

Comments

@koushki
Copy link

@koushki koushki commented Apr 19, 2020

What version of Go are you using (go version)?

$ go version
go1.14.2 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build332853226=/tmp/go-build -gno-record-gcc-switches"

What did you do?

While using GODEBUG=asyncpreemptoff=1 if you send a sigurg sig to a thread, the scheduler will preempt the running G.

package main

import (
	"fmt"
	"runtime"
	"time"
	"golang.org/x/sys/unix"
)

func main() {
	runtime.GOMAXPROCS(1)
	go func() {
		fmt.Printf("tid %d\n", unix.Gettid())
		for {
		}
	}()
	time.Sleep(time.Second)
	fmt.Println("Done!")
}

then run it with asyncpreemptoff

GODEBUG=asyncpreemptoff=1 go run main.go
tid 2782

now use the tid to send the sig

kill -s sigurg 2782

What did you expect to see?

Since we use asyncpreemptoff=1 i expect the app shouldn't be finished!

What did you see instead?

the program prints Done!

@koushki koushki changed the title can preempt running G asynchronously by sending sigurg while asyncpreemptoff is set runtime: can preempt running G asynchronously by sending sigurg while asyncpreemptoff is set Apr 19, 2020
@ianlancetaylor ianlancetaylor added the NeedsInvestigation label Apr 19, 2020
@ianlancetaylor ianlancetaylor added this to the Go1.15 milestone Apr 19, 2020
@ianlancetaylor ianlancetaylor removed this from the Go1.15 milestone Jun 26, 2020
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Jun 26, 2020
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 26, 2020

CC @aclements @cherrymui

@cherrymui
Copy link
Member

@cherrymui cherrymui commented Jun 26, 2020

We could do let SIGURG not preempt if asyncpreemptoff is set.

I wonder what is the reason behind this. Are you running a program that you don't want to be preempted and it also receives external SIGURGs?

@koushki
Copy link
Author

@koushki koushki commented Jun 26, 2020

I don't have specific use case, i was checking how preemption is implemented and find this problem, however i think if somebody wants to use asyncpreemptoff flag, he/she wants to prevent preemption for some specific reason, but this is only my assumption.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 26, 2020

Change https://golang.org/cl/240121 mentions this issue: runtime: don't preempt if preemption is disabled

@networkimprov
Copy link

@networkimprov networkimprov commented Jun 26, 2020

Backport candidate?

Also the CL didn't include a test to verify that preemption is disabled...

@cherrymui
Copy link
Member

@cherrymui cherrymui commented Jun 26, 2020

I don't think this needs backport. As @koushki noted, it doesn't seem to affect any real program (for now).

@networkimprov
Copy link

@networkimprov networkimprov commented Jun 26, 2020

And re the lack of a test for preemption disabled?

@golang golang locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

5 participants