Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add configuration to disable links on hover #38573

Open
shreyaskarnik opened this issue Apr 21, 2020 · 4 comments
Open

x/tools/gopls: add configuration to disable links on hover #38573

shreyaskarnik opened this issue Apr 21, 2020 · 4 comments

Comments

@shreyaskarnik
Copy link

@shreyaskarnik shreyaskarnik commented Apr 21, 2020

I am using gopls with VSCode and have the following setup in settings:

"go.languageServerExperimentalFeatures": {
    "documentLink": false,
  }

but still I see links to the documents
image

What version of Go are you using (go version)?

$ go version go1.14.2 darwin/amd64

gopls version information

golang.org/x/tools/gopls 0.4.0
    golang.org/x/tools/gopls@v0.4.0 h1:G4+YP9kaV4dJb79J5MobyApxX493Qa6VoiTceUmxqik=

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"

What did you do?

What did you expect to see?

I expected the links to be disabled

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 21, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label Apr 21, 2020
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 21, 2020

documentLink refers to the feature that makes links that appear in strings or comments clickable. There is no setting to control the links to the documentation that appear on hover (other than "gopls": { "hoverKind": "NoDocumentation" }, which would remove all documentation as well as the links).

@shreyaskarnik
Copy link
Author

@shreyaskarnik shreyaskarnik commented Apr 21, 2020

@stamblerre thanks for the response! This release of gopls has been very stable and feature packed 🙌 ! Thanks again to everyone who made this possible!

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 22, 2020

Glad to hear that it's working for you, @shreyu86! Thank you for the kind words!

I'll leave this issue open to see if we can add another configuration to remove the links on hover.

@stamblerre stamblerre changed the title tools/gopls: document link disable not working x/tools/gopls: add configuration to disable links on hover Jun 24, 2020
@gopherbot gopherbot added the Tools label Jun 24, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 24, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.